Browsing sidebar: Add content menu items preview #29225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +935 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
david-szabo97
added
the
[Feature] Site Editor
david-szabo97
requested review from
vindl,
jeyip,
mattwiebe,
Addison-Stavlo and
Copons
david-szabo97
changed the title
Addison-Stavlo
approved these changes
Feb 23, 2021
creativecoder
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Will add my ✅ as well, this works as expected for me, and brings parity between the content and template previews that are generated from the sidebar.
A couple of related issues (which I think should be addressed separately from this PR, as they affect both kinds of previews from the sidebar):
First, preview performance can be quite slow when there are many posts contained in it (such as with a category archive)
Second, it looks like all the rendering and network requests are being done for smaller screens, even when the preview doesn't display
This was referenced Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29164
Description
Add previews for content menu items.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: